linux-kernel - [PATCH 2.6.25-rc7] fix uevent action-string regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2008 19:05:25 -0400
From:	Mark Lord <lkml@....ca>
To:	Greg KH <gregkh@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: [PATCH 2.6.25-rc7] fix uevent action-string regression

Mark Lord wrote:
> 
> On boot, syslog is flooded with "uevent: unsupported action-string;" messages.
..
> Mar 28 14:43:29 shrimp kernel: tty ptyqd: uevent: unsupported 
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyqe: uevent: unsupported 
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyqf: uevent: unsupported 
> action-string; this will be ignored in a future kernel version
> Mar 28 14:43:29 shrimp kernel: tty ptyr0: uevent: unsupported 
> action-string; this will be ignored in a future kernel version
..

These messages are a regression compared with 2.6.24,
which did not flood the syslog with them.

The actual underlying problem was introduced in 2.6.23,
when somebody made the string parsing no longer accept nul-terminated
strings as a valid input to store_uevent().

Eg. "add\0" was valid prior to 2.6.23, where the code regressed
to require "add" without the '\0'.

This patch fixes the 2.6.23 / 2.6.24 regressions, by having the code
once again tolerate the trailing '\0', if present.

According to GregKH, this mainly affects older Ubuntu systems,
such as the one I have here that requires this fix.

Signed-off-by: Mark Lord <mlord@...ox.com>

--- old/lib/kobject_uevent.c	2008-03-28 14:03:46.000000000 -0400
+++ linux/lib/kobject_uevent.c	2008-03-28 18:53:11.000000000 -0400
@@ -55,7 +55,7 @@
 	enum kobject_action action;
 	int ret = -EINVAL;
 
-	if (count && buf[count-1] == '\n')
+	if (count && (buf[count-1] == '\n' || buf[count-1] == '\0'))
 		count--;
 
 	if (!count)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/