linux-kernel - Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2008 16:10:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	m.kozlowski@...land.pl
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	greg@...ah.com, sparclinux@...r.kernel.org
Subject: Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic
 pci_enable_resources()

From: Mariusz Kozlowski <m.kozlowski@...land.pl>
Date: Fri, 28 Mar 2008 23:52:10 +0100

> 	The gregkh-pci-pci-sparc64-use-generic-pci_enable_resources.patch which
> replaces arch-specific code with generic pci_enable_resources() makes my sparc64
> box unable to boot (that's what quilt bisection says). At first I see these messages:

Yes, that generic code won't work because of the NULL
r->parent check.

Alpha, ARM, V32, FRV, IA64, MIPS, MN10300, PARISC, PPC,
SH, V850, X86, and Xtensa are all likely to run into
problems because of this change.

The only platform that did the check as a test of r->parent
being NULL is Powerpc.

The rest either didn't check (like sparc64), or tested it by going:

	if (!r->start && r->end)

So the amount of potential breakage from this change is enormous.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/