linux-kernel - Re: sound/core.h: evil #ifdefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080329213943.GA15507@elf.ucw.cz>
Date:	Sat, 29 Mar 2008 22:39:43 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	perex@...ex.cz, kernel list <linux-kernel@...r.kernel.org>,
	Trivial patch monkey <trivial@...nel.org>, tiwai@...e.de
Subject: Re: sound/core.h: evil #ifdefs

Hi!

> > snd_minor_info_oss_* is an function returning int _or_ comment,
> > depending on config parameters. That is truly evil, fix it.
> > 
> > Signed-off-by: Pavel Machek <pavel@...e.cz>
> > 
> > diff --git a/include/sound/core.h b/include/sound/core.h
> > index 4fc0235..452000d 100644
> > --- a/include/sound/core.h
> > +++ b/include/sound/core.h
> > @@ -277,8 +277,8 @@ #ifdef CONFIG_SND_OSSEMUL
> >  int snd_minor_info_oss_init(void);
> >  int snd_minor_info_oss_done(void);
> >  #else
> > -#define snd_minor_info_oss_init() /*NOP*/
> > -#define snd_minor_info_oss_done() /*NOP*/
> > +static inline snd_minor_info_oss_init(void) { return 0; }
>    static inline int snd_minor_info_oss_init(void) { return 0; }
> 
> > +static inline snd_minor_info_oss_done(void) { return 0; }
>    static inline int snd_minor_info_oss_done(void) { return 0; }
> >  #endif

yep, thanks, scratch that patch.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/