linux-kernel - Re: [PATCH RFC] hotplug-memory: refactor online_pages to separate zone growth from page onlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080329152651.e2c40a0c.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Sat, 29 Mar 2008 15:26:51 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Yasunori Goto <y-goto@...fujitsu.com>,
	Christoph Lameter <clameter@....com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] hotplug-memory: refactor online_pages to separate
 zone growth from page onlining

On Fri, 28 Mar 2008 22:48:21 -0700
Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> >> -	if (onlined_pages)
> >> +	if (onlined_pages) {
> >> +		struct memory_notify arg;
> >> +
> >> +		arg.start_pfn = pfn;  /* ? */
> >> +		arg.nr_pages = onlined_pages;
> >> +		arg.status_change_nid = -1;  /* ? */
> >> +
> >>  		memory_notify(MEM_ONLINE, &arg);
> >> +	}
> >>     
> > I think you should add "onlined" member instead of reusing nr_pages.
> >   
> 
> I suppose.  What would I put into nr_pages?  And anyway, there are no 
> users for this notification...
> 
My point is "Notifier" is expexted to work correctly and include precise
information regardless of users.

> > But, in general, I have no objection to this way.
> >   
> 
> The refactoring in general?
> 

Separating online_pages() into some meaningful blocks. Then, you can
reuse some parts and avoid dupilication.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/