linux-kernel - Re: [RFC 8/8] x86_64: Support for new UV apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080330210843.GB13383@sgi.com>
Date:	Sun, 30 Mar 2008 16:08:43 -0500
From:	Jack Steiner <steiner@....com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	mingo@...e.hu, tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 8/8] x86_64: Support for new UV apic

> >   unsigned int get_apic_id(void)
> >   {
> >  -       return (apic_read(APIC_ID) >> 24) & 0xFFu;
> >  +       unsigned int id;
> >  +
> >  +       preempt_disable();
> >  +       id = apic_read(APIC_ID);
> >  +       if (uv_system_type >= UV_X2APIC)
> >  +               id  |= __get_cpu_var(x2apic_extra_bits);
> >  +       else
> >  +               id = (id >> 24) & 0xFFu;;
> >  +       preempt_enable();
> >  +       return id;
> >
> 
> you can not shift id here.
> 
> GET_APIC_ID will shift that again.
> 
> you apic id will be 0 for all cpu
> 

I think this is fixed in the patch that I submitted on Friday. I
had to rework the GET_APIC_ID() changes because of the unification
of -32 & -64 apic code. I think the new code is much cleaner...


--- jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/