linux-kernel - Re: style of function definitions (Re: [patch] bkl2mtd: cleanup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0803300727120.28605@fbirervta.pbzchgretzou.qr>
Date:	Sun, 30 Mar 2008 07:31:30 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Oleg Verych <olecom@...wer.upol.cz>
cc:	Ingo Molnar <mingo@...e.hu>, Al Viro <viro@...IV.linux.org.uk>,
	Joern Engel <joern@...fs.org>,
	David Miller <davem@...emloft.net>, jirislaby@...il.com,
	joe@...ches.com, tglx@...utronix.de, linux-kernel@...r.kernel.org,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: style of function definitions (Re: [patch] bkl2mtd: cleanup)


On Sunday 2008-03-30 06:29, Oleg Verych wrote:
> []
>>>> -static int block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len,
>>>> +static int
>>>> +block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len,
>>>>  		size_t *retlen, const u_char *buf)
>>>
>>> Again, why split it that way?
>>
>> these are really nuances, so unless you are interested in such nuances
>> nowhere found in CodingStyle, stop reading here :-)
>
> Nuances, or not, there are all kinds of stuff in Linux. Very small
> journey from simple `grep` and trivial multi-line `sed` to a huge
> discovery can be found here:
>
> http://kernelnewbies.org/olecom#Function_definitions
>
> No matter what coding style is, the winner is "linux-2.6/fs/xfs", and
> i doubt anyone can fix that :)

They at least have an excuse of having a historical unix background :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/