linux-kernel - Re: [PATCH 8/35] W1: feature, w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080330113003.GD15122@2ka.mipt.ru>
Date:	Sun, 30 Mar 2008 15:30:03 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Fries <david@...es.net>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/35] W1: feature, w1_therm.c use strong pullup

On Fri, Mar 28, 2008 at 07:25:10AM -0500, David Fries (david@...es.net) wrote:
> w1_therm.c 1.3 1.4 1.10
> Use the strong pullup not the sleep.  Note that the pullup goes before
> W1_CONVERT_TEMP not after.
> +w1_next_pullup(dev, tm);
>  w1_write_8(dev, W1_CONVERT_TEMP);
> -msleep(tm);

I'm ok with it, but believe it has to be turned off by default and be
able to be turned on by parameter.

Did you test it with multiple devices on the same bus?

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/