linux-kernel - Re: [PATCH] x86: create array based interface to change page attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2008 13:46:46 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Dave Airlie <airlied@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>, Dave Airlie <airlied@...hat.com>,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	arjan@...ux.intel.com, thomas@...gstengraphics.com
Subject: Re: [PATCH] x86: create array based interface to change page attribute

On Mon, Mar 31, 2008 at 09:21:19PM +1000, Dave Airlie wrote:
> On Mon, Mar 31, 2008 at 5:25 PM, Andi Kleen <andi@...stfloor.org> wrote:
> > Dave Airlie <airlied@...hat.com> writes:
> >  >
> >  > +#define CPA_FLUSHTLB 1
> >  > +#define CPA_ARRAY 2
> >
> >  I don't think CPA_ARRAY should be a separate case. Rather single
> >  page flushing should be an array with only a single entry. pageattr
> >  is already very complex, no need to make add more special cases.
> 
> I thought about this but the current interface takes a start address
> and number of pages from that point to cpa,
> the array interface takes an array of page sized pages.
> 
> I don't really think we need to generate an array in the first case
> with all the pages in it..

Just put the length into the array members too.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/