linux-kernel - [PATCH] percpu: Introduce DEFINE_PER_CPU_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <47F101AE.3020802@cosmosbay.com>
Date:	Mon, 31 Mar 2008 17:22:22 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	linux kernel <linux-kernel@...r.kernel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Christoph Lameter <clameter@....com>
Subject: [PATCH] percpu: Introduce DEFINE_PER_CPU_PAGE_ALIGNED() macro 

While examining holes in percpu section I found this :

c05f5000 D per_cpu__current_task
c05f5000 D __per_cpu_start
c05f5004 D per_cpu__cpu_number
c05f5008 D per_cpu__irq_regs
c05f500c d per_cpu__cpu_devices
c05f5040 D per_cpu__cyc2ns

<Big Hole of about 4000 bytes>

c05f6000 d per_cpu__cpuid4_info
c05f6004 d per_cpu__cache_kobject
c05f6008 d per_cpu__index_kobject

<Big Hole of about 4000 bytes>

c05f7000 D per_cpu__gdt_page

This is because gdt_page is a percpu variable, defined with
a page alignement, and linker is doing its job, two times because of .o 
nesting in the build process.

I introduced a new macro DEFINE_PER_CPU_PAGE_ALIGNED() to avoid
wasting this space. All page aligned variables (only one at this time) 
are put in a separate
subsection .data.percpu.page_aligned, at the very begining of percpu zone.

Before patch , on a x86_32 machine :

# size -A vmlinux.old vmlinux | grep percpu
.data.percpu                30232   3227471872
.data.percpu                22168   3227471872

Thats 8064 bytes saved for each CPU.

Patch against x86.git/latest

Note : This will collide with Christoph efforts to put pda at offset 0 
of percpu zone...

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

 arch/x86/kernel/cpu/common.c      |    2 +-
 arch/x86/kernel/vmlinux_32.lds.S  |    1 +
 include/asm-generic/vmlinux.lds.h |    1 +
 include/linux/percpu.h            |    7 +++++++
 4 files changed, 10 insertions(+), 1 deletion(-)

View attachment "DEFINE_PER_CPU_PAGE_ALIGNED.patch" of type "text/plain" (2254 bytes)