linux-kernel - Re: [PATCH 8/8] x86_64: Support for new UV apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440803301927g42e6d8a2lf357bd5400fefc46@mail.gmail.com>
Date:	Sun, 30 Mar 2008 19:27:25 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Jack Steiner" <steiner@....com>
Cc:	"Andi Kleen" <ak@...e.de>, mingo@...e.hu, tglx@...utronix.de,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] x86_64: Support for new UV apic

On Sun, Mar 30, 2008 at 7:23 PM, Jack Steiner <steiner@....com> wrote:
>
> On Sun, Mar 30, 2008 at 07:13:42PM -0700, Yinghai Lu wrote:
>  > On Sun, Mar 30, 2008 at 7:06 PM, Jack Steiner <steiner@....com> wrote:
>  > > > so this is "the new one of Friday"?
>  > >
>  > >  Yes, and it has the same bug although it is located
>  > >  in a slightly different place.
>  > >
>  > >  A few minutes ago, I posted a patch to delete the extra lines.
>  > >
>  > >
>  > >
>  > >  > Did you test it on non UV_X2APIC box?
>  > >
>  > >  The code is clearly wrong.  I booted on an 8p AMD box and
>  > >  had no problems. Apparently the kernel (at least basic booting) is
>  > >  not too sensitive to incorrect apicids being returned. Most
>  > >  critical-to-boot code must use apicids from the ACPI tables.
>  > >  However, the bug does affect numa node assignment. And probably
>  > >  other places, too.
>  >
>  > please consider one global get_apic_id() and bad_apicid to replace
>  > GET_APIC_ID and BAD_APICID at this point.
>
>  I think that makes sense.
>
>  The x2apic patch that should be posted in the near future also makes
>  significant changes in this area.  Once that patch is posted, I'll
>  make the simplifications.
>
>  Ok???

good.

with the x2apic patch, GET_APIC_ID is read_apic_id, and it will not shift again?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/