linux-kernel - Re: [ANNOUNCE] Btrfs v0.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080331210252.GA2362@ldl.fc.hp.com>
Date:	Mon, 31 Mar 2008 15:02:52 -0600
From:	Alex Chiang <achiang@...com>
To:	Chris Mason <chris.mason@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	btrfs-devel@....oracle.com
Subject: Re: [ANNOUNCE] Btrfs v0.13

* Chris Mason <chris.mason@...cle.com>:
> 
> Great, thanks I'll take these two.  The kernel side needs the
> same hash.c fix, but I've already got that change made locally.

Here's a patch for the kernel side.

/ac

Subject: [PATCH] btrfs: Stop trashing 'name' arg of btrfs_name_hash
From: Alex Chiang <achiang@...com>

In btrfs_name_hash, Local variable 'buf' is declared as

        __u32 buf[2];

but we then try to do this:

        buf[0] = 0x67452301;
        buf[1] = 0xefcdab89;
        buf[2] = 0x98badcfe;
        buf[3] = 0x10325476;

Oops. Fix buf to be the proper size.

Signed-off-by: Alex Chiang <achiang@...com>

diff -r e4cd88595ed7 -r 03942eecb56d hash.c
--- a/hash.c	Thu Feb 21 14:54:12 2008 -0500
+++ b/hash.c	Mon Mar 31 14:58:00 2008 -0600
@@ -81,7 +81,7 @@ u64 btrfs_name_hash(const char *name, in
 	__u32	hash;
 	__u32	minor_hash = 0;
 	const char	*p;
-	__u32		in[8], buf[2];
+	__u32		in[8], buf[4];
 	u64		hash_result;
 
 	if (len == 1 && *name == '.') {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/