linux-kernel - Re: [RFC PATCH 26/26] UBIFS: include FS to compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Apr 2008 13:04:11 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	Artem.Bityutskiy@...ia.com
Cc:	"Artem Bityutskiy" <dedekind@...dex.ru>,
	LKML <linux-kernel@...r.kernel.org>,
	"Adrian Hunter" <ext-adrian.hunter@...ia.com>,
	"David Woodhouse" <dwmw2@...radead.org>
Subject: Re: [RFC PATCH 26/26] UBIFS: include FS to compilation

Hi Artem,

Pekka Enberg wrote:
> > Yeah, perhaps that's a sign that you're doing it wrong? You currently
> > have 430 separate debug printks sprinkled around in UBIFS.

On Tue, Apr 1, 2008 at 12:25 PM, Artem Bityutskiy
<Artem.Bityutskiy@...ia.com> wrote:
> JFFS2 has the similar thing. I myself fixed bugs just by asking people
> enabling them and sending the log. Very useful. This is why we also added
> them to UBIFS - good JFFS2 experience.
>
> Why? What is wrong with this? As I said, we found it very useful in JFFS2,
> because I has been working with JFFS2 for _long_ time. Talk to David
> Woodhouse and ask how many times that made him fix a bug just by having
> people send a log. Why do you want to prevent us from having this?

First and foremost, JFFS2 uses BUG_ON and doesn't invent it's own
assert. Furthermore, the debug tracing code prints out human-readable
text in well-thought of places. It's looks bit excessive to me and I
don't see a good reason why the different logging levels are not
run-time configurable (if you're going to invent a logging
infrastructure, why not do it properly). But there simply is no
comparison between JFFS2 and UBIFS debug logging code. The former is
cleanly structured whereas yours looks to be totally ad hoc.

But perhaps the problem will go away after you inject some sanity to
stuff like this:

fs/ubifs/dir.c: dbg_gen("dent '%.*s' to ino %lu (nlink %d) in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("dent '%.*s' from ino %lu (nlink %d) in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("directory '%.*s', ino %lu in dir ino %lu",
dentry->d_name.len,
fs/ubifs/dir.c: dbg_gen("dent '%.*s', mode %#x in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("dent '%.*s' in dir ino %lu",

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/