linux-kernel - Re: [PATCH] Fix tosakbd suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080401034903.GB18041@anvil.corenet.prv>
Date:	Mon, 31 Mar 2008 23:49:03 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dmitry Baryshkov <dbaryshkov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix tosakbd suspend

Hi Dmitry,

On Tue, Apr 01, 2008 at 01:38:01AM +0400, Dmitry Baryshkov wrote:
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@...il.com>
> ---
>  drivers/input/keyboard/tosakbd.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/keyboard/tosakbd.c b/drivers/input/keyboard/tosakbd.c
> index 3884d1e..306cbe8 100644
> --- a/drivers/input/keyboard/tosakbd.c
> +++ b/drivers/input/keyboard/tosakbd.c
> @@ -210,6 +210,9 @@ static int tosakbd_suspend(struct platform_device *dev, pm_message_t state)
>  
>  	del_timer_sync(&tosakbd->timer);
>  

What if interrupt comes here? The whole suspend path seems racy with
interrup handler/timer.

> +	PGSR1 = (PGSR1 & ~TOSA_GPIO_LOW_STROBE_BIT);
> +	PGSR2 = (PGSR2 & ~TOSA_GPIO_HIGH_STROBE_BIT);
> +
>  	return 0;
>  }
>  

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/