linux-kernel - Re: [patch 5/9] Convert anon_vma lock to rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804021107520.27337@schroedinger.engr.sgi.com>
Date:	Wed, 2 Apr 2008 11:15:26 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Andrea Arcangeli <andrea@...ranet.com>
cc:	Hugh Dickins <hugh@...itas.com>, Robin Holt <holt@....com>,
	Avi Kivity <avi@...ranet.com>, Izik Eidus <izike@...ranet.com>,
	kvm-devel@...ts.sourceforge.net,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	general@...ts.openfabrics.org,
	Steve Wise <swise@...ngridcomputing.com>,
	Roland Dreier <rdreier@...co.com>,
	Kanoj Sarcar <kanojsarcar@...oo.com>, steiner@....com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	daniel.blueman@...drics.com
Subject: Re: [patch 5/9] Convert anon_vma lock to rw_sem and refcount

On Wed, 2 Apr 2008, Andrea Arcangeli wrote:

> On Tue, Apr 01, 2008 at 01:55:36PM -0700, Christoph Lameter wrote:
> >   This results in f.e. the Aim9 brk performance test to got down by 10-15%.
> 
> I guess it's more likely because of overscheduling for small crtitical
> sections, did you counted the total number of context switches? I
> guess there will be a lot more with your patch applied. That
> regression is a showstopper and it is the reason why I've suggested
> before to add a CONFIG_XPMEM or CONFIG_MMU_NOTIFIER_SLEEP config
> option to make the VM locks sleep capable only when XPMEM=y
> (PREEMPT_RT will enable it too). Thanks for doing the benchmark work!

There are more context switches if locks are contended. 

But that has actually also some good aspects because we avoid busy loops 
and can potentially continue work in another process.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/