linux-kernel - Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804022211.36438.oliver@neukum.org>
Date:	Wed, 2 Apr 2008 22:11:35 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Nigel Cunningham <ncunningham@...a.org.au>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Len Brown <lenb@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	David Brownell <david-b@...bell.net>,
	Pavel Machek <pavel@....cz>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)

Am Mittwoch, 2. April 2008 18:42:15 schrieb Alan Stern:
> On Wed, 2 Apr 2008, Oliver Neukum wrote:
> 
> > Am Mittwoch, 2. April 2008 17:13:11 schrieb Alan Stern:
> > > Basically yes.  Subsystems and drivers are allowed to keep devices
> > > suspended if they were suspended before the system went to sleep.  
> > > Remember, the purpose of the resume method is to let drivers know that
> > > the system is now awake, not to force them to put their devices into a
> > > high-power state.
> > 
> > Well, sometimes it is exactly that what we desire, eg. as a side effect
> > of lsusb. Should the callbacks have different semantics depending on
> > the reason you call them? And how should that information be transferred?
> 
> Which callbacks are you referring to?  When lsusb opens a device and
> does an autoresume, it does not call the same routine as the PM core
> does when resuming from a system sleep.  lsusb ends up calling
> usb_autoresume_device() whereas the PM core ends up calling
> usb_resume(), which is the function you quoted earlier.

But how is usb_autoresume_device() supposed to take to the driver?
Furthermore suppose the interface woken up is storage. This will have
to work across subsystem borders. Why not put it into generic code?

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/