linux-kernel - Re: [PATCH]: Fix SMP-reordering race in mark_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0804021548440.14670@woody.linux-foundation.org>
Date:	Wed, 2 Apr 2008 15:51:56 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>
cc:	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: Fix SMP-reordering race in mark_buffer_dirty



On Thu, 3 Apr 2008, Mikulas Patocka wrote:
> 
> When I added memory reads around mfence, the combined result was worse 
> than the sum of reads and mfence --- mfence alone 8 ticks, mfence+4reads 
> 18 ticks.

Sorry, my test-program was buggy.

> mfence+writes scales linearly, i.e. mfence + 4 writes does 12 ticks.

I get different results now that I fixed my memop test. I get a loop with 
reads and writes taking 3 cycles without mfence, and 21 cycles with (read 
after, write before). 

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/