linux-kernel - Re: [RFC 01/22] Generic show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080403124820.GA30356@uranus.ravnborg.org>
Date:	Thu, 3 Apr 2008 14:48:20 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Johannes Weiner <hannes@...urebad.de>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, mingo@...e.hu,
	davem@...emloft.net, hskinnemoen@...el.com, cooloney@...nel.org,
	starvik@...s.com, dhowells@...hat.com, ysato@...rs.sf.net,
	takata@...ux-m32r.org, geert@...ux-m68k.org, ralf@...ux-mips.org,
	kyle@...isc-linux.org, paulus@...ba.org, schwidefsky@...ibm.com,
	lethal@...ux-sh.org, jdike@...toit.com, miles@....org,
	chris@...kel.net, rmk@....linux.org.uk, tony.luck@...el.com
Subject: Re: [RFC 01/22] Generic show_mem() implementation

On Thu, Apr 03, 2008 at 09:55:45AM +0200, Heiko Carstens wrote:
> > diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig
> > index 729cdbd..efffa92 100644
> > --- a/arch/alpha/Kconfig
> > +++ b/arch/alpha/Kconfig
> > @@ -598,6 +598,9 @@ config ALPHA_LARGE_VMALLOC
> > 
> >  	  Say N unless you know you need gobs and gobs of vmalloc space.
> > 
> > +config HAVE_ARCH_SHOW_MEM
> > +	def_bool y
> > +
> >  config VERBOSE_MCHECK
> >  	bool "Verbose Machine Checks"
> > 
> > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> > index 76348f0..acad217 100644
> > --- a/arch/arm/mm/Kconfig
> > +++ b/arch/arm/mm/Kconfig
> > @@ -673,3 +673,6 @@ config OUTER_CACHE
> >  config CACHE_L2X0
> >  	bool
> >  	select OUTER_CACHE
> > +
> > +config HAVE_ARCH_SHOW_MEM
> > +	def_bool y
> 
> These are all not necessary. Better add some global Kconfig option that
> gets selected by an arch if it wants the generic implementation.
> 
> e.g. we currently have this in arch/s390/Kconfig:
> 
> config S390
>         def_bool y
>         select HAVE_OPROFILE
>         select HAVE_KPROBES
>         select HAVE_KRETPROBES
> 
> just add a select HAVE_GENERIC_SHOWMEM or something like that in the arch
> specific patches.
Seconded.
See Documentation/kbuild/kconfig-language.txt for a few more hints
how to do it.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/