linux-kernel - [PATCH] x86: fix miscompile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1207234418.3048.25.camel@localhost.localdomain>
Date:	Thu, 03 Apr 2008 09:53:38 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86: fix miscompile

This patch local to the x86 tree introduced a fairly obvious compile
fault:

commit f22fc9998497af6c271385e2025e2fe71c6f15b0
Author: Ingo Molnar <mingo@...e.hu>
Date:   Wed Apr 2 12:20:18 2008 +0200

    x86: allocate FPU context to init task

I've attached the fix below (INIT_THREAD is a #defined initializer, not
an actual structure).  However, if you get this tree into linux-next,
they'll do a much better job of shaking out bugs like this than I could.

James

---

diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h
index d4686cf..2fad98d 100644
--- a/include/asm-x86/processor.h
+++ b/include/asm-x86/processor.h
@@ -828,7 +828,7 @@ extern union thread_xstate init_xstate;
 	.sysenter_cs		= __KERNEL_CS,				  \
 	.io_bitmap_ptr		= NULL,					  \
 	.fs			= __KERNEL_PERCPU,			  \
-	.xstate			= &init_xstate;
+	.xstate			= &init_xstate,				  \
 }
 
 /*


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/