linux-kernel - Re: [RFC][PATCH 1/3] use new pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804031441.07703.jbarnes@virtuousgeek.org>
Date:	Thu, 3 Apr 2008 14:41:07 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	pm list <linux-pm@...ts.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg KH <greg@...ah.com>, Len Brown <lenb@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@...e.de>,
	David Brownell <david-b@...bell.net>,
	Pavel Machek <pavel@....cz>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Oliver Neukum <oliver@...kum.org>,
	Nigel Cunningham <ncunningham@...a.org.au>,
	Dave Airlie <airlied@...ux.ie>
Subject: Re: [RFC][PATCH 1/3] use new pm_ops in DRM drivers

On Thursday, April 03, 2008 2:23 pm Rafael J. Wysocki wrote:
> > +static int i915_poweroff(struct device *dev)
> > +{
> > +	/* Shut down the device */
> > +	pci_disable_device(dev->pdev);
> > +	pci_set_power_state(dev->pdev, PCI_D3hot);
>
> I think you may need to do that in ->suspend() too, as opposed to
> ->freeze(), ...

Because ->poweroff won't be called in the paths that do ->suspend?  Ah yeah, 
must have skipped over that section of the documentation...

>
> > +}
> > +
> > +static struct pm_ops i915_pm_ops = {
> > +	.prepare = NULL, /* DRM core should prevent any new ioctls? */
> > +	.complete = NULL, /* required to re-enable DRM client requests */
> > +	.suspend = i915_save,
> > +	.resume = i915_restore,
> > +	.freeze = i915_save,
>
> ... so perhaps define ->suspend() as ->save() + ->poweroff()?

Yep, I can just make a wrapper for it in the driver.

Thanks a lot for making these changes to the core.  My only worry is that all 
the old-style stuff will stick around forever...  so fwiw you can add my

Acked-by:  Jesse Barnes <jesse.barnes@...el.com>

to the series.

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/