linux-kernel - Re: HugeTLB vs. SH3 cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080403055235.GC4171@linux-sh.org>
Date:	Thu, 3 Apr 2008 14:52:35 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Nish Aravamudan <nish.aravamudan@...il.com>,
	Adrian Bunk <bunk@...nel.org>, wli@...omorphy.com,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: HugeTLB vs. SH3 cpu

On Wed, Apr 02, 2008 at 11:15:38AM +0100, Mel Gorman wrote:
> On (02/04/08 17:04), Paul Mundt didst pronounce:
> > The problem is that the hugetlb Kconfig stuff is a complete mess. There's
> > a semi-decoupling between HUGETLBFS and HUGETLB_PAGE, though they both
> > depend on each other.
> 
> I believe the original intention was that HUGETLB_PAGE would build the
> hugepage pool and the arch-specific code and HUGETLBFS would be the userspace
> interface but not necessarily the only one. Whatever the original intention,
> it's no longer the case as they have become inter-dependant. Fixing it is
> not straight-forward but I don't think we want to collapse HUGETLB_PAGE and
> HUGETLBFS just yet either.
> 
That makes more sense, perhaps it's worth beating in to shape so there
can also be non hugetlbfs users, this needs a bit of use-case thinking,
though.

> > diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
> > index 0c3face..7c937ad 100644
> > --- a/arch/powerpc/platforms/Kconfig.cputype
> > +++ b/arch/powerpc/platforms/Kconfig.cputype
> > @@ -1,5 +1,6 @@
> >  config PPC64
> >  	bool "64-bit kernel"
> > +	select HAVE_HUGETLB_PAGE
> >  	default n
> >  	help
> >  	  This option selects whether a 32-bit or a 64-bit kernel
> 
> hmm... This is what Kconfig is currently doing but by rights, it should be
> set on a per-processor basis. I guess it's outside the scope of this patch as
> there isn't an obvious way to tell what processor versions support huge pages.
> 
Yes, I had the same thoughts, perhaps the PPC64 folks can shed some light
on this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/