linux-kernel - Re: [patch 05/22 -v2] blackfin: Use generic show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <386072610804040743t162cce4ap5ef6ec178374ce0e@mail.gmail.com>
Date:	Fri, 4 Apr 2008 07:43:18 -0700
From:	"Bryan Wu" <cooloney@...nel.org>
To:	hannes@...urebad.de
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [patch 05/22 -v2] blackfin: Use generic show_mem()

On Fri, Apr 4, 2008 at 4:51 AM,  <hannes@...urebad.de> wrote:
> Remove arch-specific show_mem() in favor of the generic version.
>
>  This also removes the following redundant information display:
>
>         - free pages, printed by show_free_areas()
>         - pages in swapcache, printed by show_swap_cache_info()
>
>  where show_mem() calls show_free_areas(), which calls
>  show_swap_cache_info().
>
>  Signed-off-by: Johannes Weiner <hannes@...urebad.de>
>  CC: Bryan Wu <cooloney@...nel.org>
>  ---
>
>  Index: tree-linus/arch/blackfin/Kconfig
>  ===================================================================
>  --- tree-linus.orig/arch/blackfin/Kconfig
>  +++ tree-linus/arch/blackfin/Kconfig
>  @@ -26,7 +26,6 @@ config BLACKFIN
>         default y
>         select HAVE_IDE
>         select HAVE_OPROFILE
>  -       select HAVE_ARCH_SHOW_MEM
>
>   config ZONE_DMA
>         bool
>  Index: tree-linus/arch/blackfin/mm/init.c
>  ===================================================================
>  --- tree-linus.orig/arch/blackfin/mm/init.c
>  +++ tree-linus/arch/blackfin/mm/init.c
>  @@ -53,33 +53,6 @@ static unsigned long empty_bad_page;
>
>   unsigned long empty_zero_page;
>
>  -void show_mem(void)
>  -{
>  -       unsigned long i;
>  -       int free = 0, total = 0, reserved = 0, shared = 0;
>  -
>  -       int cached = 0;
>  -       printk(KERN_INFO "Mem-info:\n");
>  -       show_free_areas();
>  -       i = max_mapnr;
>  -       while (i-- > 0) {
>  -               total++;
>  -               if (PageReserved(mem_map + i))
>  -                       reserved++;
>  -               else if (PageSwapCache(mem_map + i))
>  -                       cached++;
>  -               else if (!page_count(mem_map + i))
>  -                       free++;
>  -               else
>  -                       shared += page_count(mem_map + i) - 1;
>  -       }
>  -       printk(KERN_INFO "%d pages of RAM\n", total);
>  -       printk(KERN_INFO "%d free pages\n", free);
>  -       printk(KERN_INFO "%d reserved pages\n", reserved);
>  -       printk(KERN_INFO "%d pages shared\n", shared);
>  -       printk(KERN_INFO "%d pages swap cached\n", cached);
>  -}
>  -
>   /*
>   * paging_init() continues the virtual memory environment setup which
>   * was begun by the code in arch/head.S.
>

Thanks
Acked-by: Bryan Wu <cooloney@...nel.org>

-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/