linux-kernel - Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 04 Apr 2008 17:52:05 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
CC:	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Greg KH <greg@...ah.com>,
	Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [ANNOUNCE] e1000 to e1000e migration of PCI Express devices

Dave Hansen wrote:
> On Fri, 2008-04-04 at 14:11 -0700, Kok, Auke wrote:
>> >From kernel 2.6.26 onward all *PCI Express* device IDs previously
>> supported by e1000 will be moving to the e1000e driver.  This includes
>> ich8 and ich9 onboard LAN, server 5000 platform onboard LAN (es2) and
>> 82571/2/3 chipset based adapters and variants.
>>
>> If you have not already enabled CONFIG_E1000E make sure that you do so.
>> You can already do this with 2.6.25.  From 2.6.26 on this change will be
>> required if you have such a device.
> 
> I've been bitten by one or two of these in the past.  Can we do
> something like this for a couple of releases?
> 
> Shouldn't this default the E1000E config option to the same thing that
> people have the E1000 set as?  It should catch the dumb people like me
> who's enter key gets held down during a 'make oldconfig'. :)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 3a0b20a..aa0fe14 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2005,6 +2005,7 @@ config E1000_DISABLE_PACKET_SPLIT
>  config E1000E
>         tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
>         depends on PCI
> +       default E1000
>         ---help---
>           This driver supports the PCI-Express Intel(R) PRO/1000 gigabit
>           ethernet family of adapters. For PCI or PCI-X e1000 adapters,

That's not pretty for embedded folks who don't want an extra driver to 
come along for the ride ;-)

It's also been suggested, as an alternative, to add 'select E1000E' to 
E1000's Kconfig entry.

Rather than doing that, I am hoping that education -- Auke's 
announcements -- plus "ripping the band-aid off quickly", will be the 
best approach.

Most kernel distributions will have enabled both Kconfig options anyway, 
so that leaves individual kernel hackers who missed the announcements as 
the only target audience for the patch quoted above.

And as a side note...  we really really try not to do this very often. 
Migrating users from one driver to another is not a seamless process in 
Linux -- but unfortuantely the alternative solution, the same PCI ID in 
multiple drivers, presents an even worse set of breakages and problems. 
  This e1000->e1000e move is an exception to the rule.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/