lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Apr 2008 09:23:23 +0200 From: Jens Axboe <jens.axboe@...cle.com> To: Oliver Pinter <oliver.pntr@...il.com> Cc: Hugh Dickins <hugh@...itas.com>, Andrew Morton <akpm@...ux-foundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] splice: use mapping_gfp_mask On Fri, Apr 04 2008, Oliver Pinter wrote: > hi all! > > this patch for 2.6.22.y ? > > if i good see, the __generic_file_splice_read bring out to 2.6.22 .. > > http://repo.or.cz/w/linux-2.6.22.y-op-patches.git > http://repo.or.cz/w/linux-2.6.22.y-op.git Loop isn't affected before 2.6.23, so while it doesn't hurt to put it into 2.6.22, there's not much point either. 2.6.23 and 24 need the patch. > > On 4/4/08, Jens Axboe <jens.axboe@...cle.com> wrote: > > On Thu, Apr 03 2008, Hugh Dickins wrote: > > > The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its > > > mapping_gfp_mask, to avoid hangs under memory pressure. But nowadays > > > it uses splice, usually going through __generic_file_splice_read. That > > > must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs. > > > > > > Signed-off-by: Hugh Dickins <hugh@...itas.com> > > > --- > > > Ought to go into 2.6.25. For 2.6.23 and 2.6.24 stable? Well, I've > > > not actually seen this hang on any of these, though presumably it's > > > lurking there. Where I did see it, and test the fix, was 2.6.25-rc5-mm1: > > > whose SLUB had a disturbing predilection (since corrected) for order-4 > > > allocations, even when allocating radix tree nodes. > > > > Thanks Hugh, definitely correct! I see it's already merged, so all is > > well. > > > > -- > > Jens Axboe > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@...r.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > -- > Thanks, > Oliver -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists