linux-kernel - Re: [patch] checkpatch: relax spacing and line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47F8B98A.1020704@panasas.com>
Date:	Sun, 06 Apr 2008 14:52:42 +0300
From:	Benny Halevy <bhalevy@...asas.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Jan Engelhardt <jengelh@...putergmbh.de>, apw@...dowen.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch] checkpatch: relax spacing and line length

On Apr. 06, 2008, 8:18 +0300, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Sun, 6 Apr 2008 06:54:54 +0200 (CEST) Jan Engelhardt <jengelh@...putergmbh.de> wrote:
> 
>>      We all had the arguments about 80 columns, so here goes a relax.
>>      Checking for 95 (or perhaps something better?), but of course we
>>      print "80" in the output, because if you happened to get to 95, it's
>>      "really time" to break it.
> 
> This will reduce the usefulness of checkpatch for those developers who
> choose to observe an 80-column limit.
> 
>>      This also relaxes the tab doctrine, because spaces DO make sense --
>>      especially when you view the code with a tab setting of not-8.
> 
> Non-tab-using code inevitably ends up having a mix of tabs and non-tabs
> and looks a mess if tabstops are set to anything other than eight.

I humbly disagree.  If you use tabs for (logical) indentation and then trailing
spaces for (graphical) alignment, not just a random mix of tabs and spaces the
code looks fine with 8-character wide tabs or any other setup.  Only when you
use tabs for graphical alignment, below fixed-width characters on the line above
you marry yourself with a specific tab expansion width.

Benny

> 
> God I wish I had not been cc'ed on this.

The idea is *not* to open the flood gates, just to allow for a bit more
flexibility to accommodate for a more robust indentation style.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/