linux-kernel - Re: [patch v2] doc: DMA-mapping.txt has undeclared variables [Bug 10397]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804070905.51499.jbarnes@virtuousgeek.org>
Date:	Mon, 7 Apr 2008 09:05:51 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	linux-pci@...ey.karlin.mff.cuni.cz
Cc:	Matti Linnanvuori <mattilinnanvuori@...oo.com>,
	Grant Grundler <grundler@...isc-linux.org>, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [patch v2] doc: DMA-mapping.txt has undeclared variables [Bug 10397]

On Monday, April 07, 2008 9:01 am Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@...oo.com>
>
> Fix undeclared variables in code examples.
> Consistently use pdev as the variable of type struct pci_dev *.
> Bug 10397.

I think Grant's comment still stands, "fix undeclared variables" isn't an 
accurate description of what you're doing here...

That said, the patch itself looks fine to me, if a bit pedantic.  The compiler 
will catch any mismatched arguments in this case, and the rest of the 
documentation is pretty clear that these routines take struct pci_dev not 
struct device, so I'd be inclined to just leave it the way it is to avoid 
churn.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/