linux-kernel - Re: [PATCH] virtio: remove overzealous BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200804080609.12891.rusty@rustcorp.com.au>
Date:	Tue, 8 Apr 2008 06:09:12 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	virtualization@...ts.linux-foundation.org
Cc:	Anthony Liguori <anthony@...emonkey.ws>,
	virtualization@...ts.osdl.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio: remove overzealous BUG_ON.

On Monday 07 April 2008 23:50:24 Anthony Liguori wrote:
> Rusty Russell wrote:
> > The 'disable_cb' callback is designed as an optimization to tell the host
> > we don't need callbacks now.  As it is not reliable, the debug check is
> > overzealous: it can happen on two CPUs at the same time.  Document this.
> >
> > Even if it were reliable, the virtio_net driver doesn't disable
> > callbacks on transmit so the START_USE/END_USE debugging reentrance
> > protection can be easily tripped even on UP.
> >
> > Thanks to Balaji Rao for the bug report and testing.
>
> I think the printk() in start_xmit should be removed too (or at least
> rate limited).

Yep, please send patch.  I'm about to jump on a plane, so consider this a 
pre-canned ack.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/