lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0804051345180.7216@anakin> Date: Sat, 5 Apr 2008 13:48:02 +0200 (CEST) From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Adrian Bunk <bunk@...nel.org> cc: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, sct@...hat.com, akpm@...ux-foundation.org, adilger@...sterfs.com, zippel@...ux-m68k.org, linux-ext4@...r.kernel.org, linux-m68k@...r.kernel.org Subject: Re: ext4 compile error on m68k On Sat, 5 Apr 2008, Adrian Bunk wrote: > Commit aa02ad67d9b308290fde390682cd039b29f7ab85 > "ext4: Add ext4_find_next_bit()" causes the following regression: > > <-- snip --> > > ... > CC [M] fs/ext4/mballoc.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/ext4/mballoc.c: In function 'mb_find_next_bit': > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/ext4/mballoc.c:696: error: implicit declaration of function 'generic_find_next_le_bit' > make[3]: *** [fs/ext4/mballoc.o] Error 1 > > <-- snip --> Known issue. The ext4 developers added a #define (with a different name than in the patch comment) in the commit below, but forgot to make sure generic_find_next_le_bit() is actually available. commit aa02ad67d9b308290fde390682cd039b29f7ab85 Author: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com> Date: Mon Jan 28 23:58:27 2008 -0500 ext4: Add ext4_find_next_bit() This function is used by the ext4 multi block allocator patches. Also add generic_find_next_le_bit Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com> Cc: <linux-ext4@...r.kernel.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> diff --git a/include/asm-m68k/bitops.h b/include/asm-m68k/bitops.h index 2976b5d..83d1f28 100644 --- a/include/asm-m68k/bitops.h +++ b/include/asm-m68k/bitops.h @@ -410,6 +410,8 @@ static inline int ext2_find_next_zero_bit(const void *vaddr res = ext2_find_first_zero_bit (p, size - 32 * (p - addr)); return (p - addr) * 32 + res; } +#define ext2_find_next_bit(addr, size, off) \ + generic_find_next_le_bit((unsigned long *)(addr), (size), (off)) #endif /* __KERNEL__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists