linux-kernel - Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f17812d70804080301j5670244dr21346e75c4744eab@mail.gmail.com>
Date:	Tue, 8 Apr 2008 18:01:46 +0800
From:	"eric miao" <eric.y.miao@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"linux-arm-kernel email list" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	linux-fbdev-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>,
	"Russell King - ARM Linux" <linux@....linux.org.uk>,
	"Daniel Mack" <daniel@...aq.de>
Subject: Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicate function

On Tue, Apr 8, 2008 at 4:21 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Tue, 8 Apr 2008 12:05:16 +0800 "eric miao" <eric.y.miao@...il.com> wrote:
>
>  > @@ -636,61 +671,31 @@ static int pxafb_activate_var(struct
>  > fb_var_screeninfo *var,
>  >               printk(KERN_ERR "%s: invalid lower_margin %d\n",
>  >                       fbi->fb.fix.id, var->lower_margin);
>  >  #endif
>  > +     /* Update shadow copy atomically */
>  > +     local_irq_save(flags);
>
>  So this code will only ever work on uniprocessor machines?
>
>  Is this a safe and reasonable assumption?
>

Y, this is a reasonable assumption for PXA2xx/3xx, though as noted in
the comment, it's too heavy for an local_irq_{save,restore} here, but
a fix to this would involve more investigation, so I'd rather have this
fixed later.

-- 
Cheers
- eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/