[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <200804081244.53894.vda.linux@googlemail.com>
Date: Tue, 8 Apr 2008 12:44:53 +0200
From: Denys Vlasenko <vda.linux@...glemail.com>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
R.E.Wolff@...wizard.nl
Subject: [PATCH] drivers/char/specialix.c: stop inlining largish static functions
Hi Alan,
drivers/char/specialix.c has unusually large number
of static inline functions - 22.
I looked through them. The file is positively inline-happy.
Inlines with udelay() calls. Inlines with complex loops.
Nested inlines. Rarely called inlines (e.g. with request_region
inside).
This patch removes "inline" from 15 static functions
(regardless of number of callsites - gcc nowadays auto-inlines
statics with one callsite).
Size difference for 32bit x86:
text data bss dec hex filename
21669 204 8780 30653 77bd linux-2.6-ALLYES/drivers/char/specialix.o
18470 204 8780 27454 6b3e linux-2.6.inline-ALLYES/drivers/char/specialix.o
Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>
--
vda
View attachment "deinline_specialix.diff" of type "text/x-diff" (9537 bytes)
Powered by blists - more mailing lists