linux-kernel - Re: [PATCH] introduce HAVE_EFFICIENT_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1207670449.5550.6.camel@johannes.berg>
Date:	Tue, 08 Apr 2008 18:00:49 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Andrew Morton <akpm@...l.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, sam <sam@...nborg.org>
Subject: Re: [PATCH] introduce HAVE_EFFICIENT_UNALIGNED_ACCESS Kconfig
	symbol

Stefan,

Thanks for the text review. I'll follow up with a new version in a
minute.

> > --- everything.orig/arch/Kconfig	2008-04-04 23:42:50.000000000 +0200
> > +++ everything/arch/Kconfig	2008-04-04 23:52:15.000000000 +0200
> > @@ -36,3 +36,22 @@ config HAVE_KPROBES
> >  
> >  config HAVE_KRETPROBES
> >  	def_bool n
> > +
> > +config HAVE_EFFICIENT_UNALIGNED_ACCESS
> > +	def_bool n
> > +	help
> > +	  Some architectures are unable to perform unaligned accesses
> > +	  without the use of get_unaligned/put_unaligned. Others are
> > +	  unable to perform such accesses efficiently (e.g. trap on
> 
> Wouldn't a comment be more appropriate instead of a help text?  This
> option shouldn't be a visible make XYZconfig prompt.
> 
> I have no comment on the option itself; it's not my domain.

Note that the help text doesn't mean the option gets to be visible, only
the one-line description does, as in

config XYZ
	bool "description"

vs.
config XYZ
	bool

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)