lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Apr 2008 00:15:17 +0200 From: Rogier Wolff <R.E.Wolff@...Wizard.nl> To: Jiri Slaby <jirislaby@...il.com> Cc: Denys Vlasenko <vda.linux@...glemail.com>, Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, R.E.Wolff@...wizard.nl Subject: Re: [PATCH] drivers/char/specialix.c: stop inlining largish static functions On Tue, Apr 08, 2008 at 11:38:11PM +0200, Jiri Slaby wrote: > > - static const char *badmagic = > + static const char badmagic[] = > KERN_ERR "sx: Warning: bad specialix port magic number for > device %s in %s\n"; [...] > if (port->magic != SPECIALIX_MAGIC) { > printk(badmagic, name, routine); > return 1; > } In a galaxy, far, far away, someone thought that this would save memory. Especially if you print a message multiple times, the compiler usually doesn't merge the string constants of two copies of: printk (KERN_ERR "Bad magic number..."); Maybe it does now. (I don't think I came up with this. I probably copied it over from somewhere....) Roger. -- ** R.E.Wolff@...Wizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 ** ** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 ** *-- BitWizard writes Linux device drivers for any device you may have! --* Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. Does it sit on the couch all day? Is it unemployed? Please be specific! Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists