linux-kernel - Re: Fix "buggy BIOS check" when CPUs are hot removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080408000348.0394dd35.akpm@linux-foundation.org>
Date:	Tue, 8 Apr 2008 00:03:48 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alok Kataria <akataria@...are.com>
Cc:	len.brown@...el.com, rui.zhang@...el.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Daniel Arai <arai@...are.com>,
	Zachary Amsden <zach@...are.com>, stable@...nel.org
Subject: Re: Fix "buggy BIOS check" when CPUs are hot removed

On Fri, 04 Apr 2008 16:48:44 -0700 Alok Kataria <akataria@...are.com> wrote:

> Fixes a BUG in ACPI hotplugging.
> 
> processor_device_array[pr->id] needs to be set to NULL when removing a
> CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
> fires when a CPU is removed from the system and then later re-added.
> 
> Signed-off-by: Alok N Kataria <akataria@...are.com>
> Signed-off-by: Dan Arai <arai@...are.com>

I assume this is also needed in 2.6.24.x?

> diff --git a/drivers/acpi/processor_core.c
> b/drivers/acpi/processor_core.c
> index 61450f4..0f95f26 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
> *device, int type)
> }
> 
> processors[pr->id] = NULL;
> + processor_device_array[pr->id] = NULL;
> 
> kfree(pr);
> 

That set a new record for patch-manglement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/