linux-kernel - Re: [NFS] Increase size of struct fid raw buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080408075807.GA8893@infradead.org>
Date:	Tue, 8 Apr 2008 03:58:07 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Steven Whitehouse <swhiteho@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Neil Brown <neilb@...e.de>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Adrian Bunk <bunk@...nel.org>
Subject: Re: [NFS] Increase size of struct fid raw buffer

On Tue, Apr 08, 2008 at 08:50:05AM +0100, Steven Whitehouse wrote:
> I'm happy with that solution, although I'd assumed that the reason this
> field had a size in the first place was that the NFS people had a plan
> to use the structure as an allocation entity in the future. Can an NFS
> developer please confirm/deny this?
> 
> If everybody is happy with the plan, then I'll send a patch to make the
> change as you suggest shortly,

I've introduce it and I don't plan to use it as allocation entity.  I
don't quite remember why I sized it either, so it's conceptually fine
to make it a VLA.  Just do some testing with that variant please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/