linux-kernel - Re: [patch 1/15] Makefiles and Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080408083316.GA31262@logfs.org>
Date:	Tue, 8 Apr 2008 10:33:17 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mtd@...ts.infradead.org
Subject: Re: [patch 1/15] Makefiles and Kconfig

On Tue, 8 April 2008 02:30:16 +0200, Arnd Bergmann wrote:
> On Tuesday 01 April 2008, joern@...fs.org wrote:
> > --- linux-2.6.24logfs/fs/Kconfig~logfs	2008-03-24 12:39:10.190939342 +0100
> > +++ linux-2.6.24logfs/fs/Kconfig	2008-04-01 19:48:18.517351063 +0200
> > @@ -1385,6 +1385,23 @@ config JFFS2_CMODE_FAVOURLZO
> >  
> >  endchoice
> >  
> > +config LOGFS
> > +	bool "Log Filesystem (EXPERIMENTAL)"
> 
> Is it really still the "Log Filesystem"? By now, I had the impression
> that "logfs" is a name by itself, so it should be called the
> "Logfs file system", and "config LOGFS_FS" respectively, like
> JFFS2_FS, REISERFS_FS, AUTOFS_FS, UDF_FS etc.

"Logfs file system" might make sense.  LOGFS_FS is something I would
rather avoid.  For some reason my brain reacts strongly to repetition,
redundancy and superfluous information.

> You shouldn't add the Makefile and Kconfig before adding the actual
> files, or you could cause git-bisect problems.

:)

I keep hearing that and I also continue to forget it.  It shouldn't
matter either way, because it simply makes no sense to merge 15 seperate
patches file-by-file for something that is functionally one change.  The
split is all about review and has nothing to do with merging.

But if I finally remembered it, at least these comments would cease.
I'll try.

Jörn

-- 
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/