linux-kernel - Re: [PATCH] usb: add sysfs configuration interface for CP2101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080409121652.GK17915@shadowen.org>
Date:	Wed, 9 Apr 2008 13:16:52 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dirk Eibach <eibach@...ys.de>, linux-kernel@...r.kernel.org,
	greg@...ah.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: add sysfs configuration interface for CP2101

On Fri, Feb 29, 2008 at 12:35:12PM -0800, Andrew Morton wrote:

> > +static int enable_config = false;
> 
> Should be either
> 
> static int enable_config;
> 
> or, if you're being very formal,
> 
> static bool enable_config = false;
> 
> or, if you're being less formal and want to avoid bloating the kernel image,
> 
> static bool enable_config;

I've added detection of false as a 0 value in external and static
contexts; this should be reported in the 0.18:

ERROR: do not initialise statics to 0 or NULL
#1: FILE: Z118.c:1:
+static bool enable_config = false;

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/