linux-kernel - Re: [patch] checkpatch: relax spacing and line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0804091517260.4411@fbirervta.pbzchgretzou.qr>
Date:	Wed, 9 Apr 2008 15:18:47 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Andy Whitcroft <apw@...dowen.org>
cc:	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch] checkpatch: relax spacing and line length


On Wednesday 2008-04-09 15:14, Andy Whitcroft wrote:
>On Wed, Apr 09, 2008 at 10:46:06AM +0200, Andi Kleen wrote:
>> > Oh, and if people felt that the concensus was for something to be
>> > implemented and that you are waiting for me to implement the change in
>> > checkpatch; please say so.
>> 
>> Well at least I think the printk change is a good one to implement and there 
>> wasn't much protest to it at least.
>
>Ok.  will put this on my todo list.

Instead of

	if (foo) {
		if (baz) {
			++x;
printk("Oh so long line makes my coding style go wary... nonsensical sentence\n");
		}
	}

I'd keep the indent and allow elongated lines:

	if (foo) {
		if (baz) {
			++x;
			printk("Oh so long line makes my coding style go wary... nonsensical sentence\n");
		}
	}

Or perhaps you just pointed out we need a smarter grep program! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/