linux-kernel - Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080409175629.GE30885@one.firstfloor.org>
Date:	Wed, 9 Apr 2008 19:56:29 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Andrew Hastings <abh@...y.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	pj@....com, linux-mm@...ck.org, nickpiggin@...oo.com.au
Subject: Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER

> This looks like an off-by-one error here and in the code below -- it 
> should be ">= MAX_ORDER" not "> MAX_ORDER".  Cf alloc_pages() in gfp.h:
> 
>         if (unlikely(order >= MAX_ORDER))
>                 return NULL;

True good point. Although it will only matter if some architecture
has MAX_ORDER sized huge pages :) x86-64 definitely hasn't.

I passed this code over to Nick so he'll hopefully incorporate the fix.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/