linux-kernel - Re: [PATCH 5/5] falconide/q40ide: add ->atapi_*put_bytes and ->ata_*put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080409181314.GA999@linux-m68k.org>
Date:	Wed, 9 Apr 2008 20:13:14 +0200
From:	Richard Zidlicky <rz@...ux-m68k.org>
To:	Michael Schmitz <schmitz@...kon.biophys.uni-duesseldorf.de>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-ide@...r.kernel.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Linux/m68k <linux-m68k@...r.kernel.org>,
	Michael Schmitz <schmitz@...ian.org>
Subject: Re: [PATCH 5/5] falconide/q40ide: add ->atapi_*put_bytes and
	->ata_*put_data methods

On Wed, Apr 09, 2008 at 03:40:34AM +0200, Michael Schmitz wrote:

> > However, not only FS data is byteswapped, complete disk including partition
> > table and everything else is. Will "rq->cmd_type == REQ_TYPE_FS" also catch
> > all these cases?
> 
>  IIRC only identify data (and perhaps ATAPI data) need to be byteswapped 
>  twice (or not at all), so REQ_TYPE_FS should catch all other cases.

my main worry is whether REQ_TYPE_FS is set even when using raw disk access,
eg reading partition table or raw partitions.

The partition table initialisation is one of the reasons why using dmapper
would be a major pain btw.

>  (Good catch about ATAPI there, BTW - I never thought about that, and ISTR 
>  that IDE CD-ROMs never worked in Linux. That would be the reason why..)

IDE CDROM works perfectly on the Q40?

Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/