linux-kernel - Re: [PATCH 0/3] x86: add cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080409203909.GA17183@suse.de>
Date:	Wed, 9 Apr 2008 13:39:09 -0700
From:	Greg KH <gregkh@...e.de>
To:	Bert Wesarg <bert.wesarg@...glemail.com>
Cc:	Mike Travis <travis@....com>, Ingo Molnar <mingo@...e.hu>,
	Paul Jackson <pj@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] x86: add cpus_scnprintf function v3

On Wed, Apr 09, 2008 at 07:51:23PM +0200, Bert Wesarg wrote:
> On Tue, Apr 8, 2008 at 8:43 PM, Mike Travis <travis@....com> wrote:
> >   * Cleanup usages of cpumask_scprintf in the following files and add
> >     another interface to use cpulist_scnprintf where appropriate.
> 
> On Mon, Apr 7, 2008 at 8:22 PM, Mike Travis <travis@....com> wrote:
> >  Part of the change is readability, but also looking towards the future
> >  of 16k/64k/??? # of cpus, the straight mask approach will overflow the
> >  PAGE_SIZE buffer provided (though some pathological cases will overflow
> >  the range method as well.)  So we'll need some advancement in the format
> >  of the printout.
> 
> Btw, I think you can now push for a deprecation of the 'old' mask
> attributes, with the justification you have given above. The other
> possibility is to change sysfs to provide bigger attribute buffers
> (CCed Greg for this).

Huh?

sysfs is "one value per file", if you are getting close to PAGE_SIZE in
any sysfs file, then you are doing something very wrong.

What sysfs file currently is trying to output data this big?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/