[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080409081943.GI17915@shadowen.org>
Date: Wed, 9 Apr 2008 09:19:53 +0100
From: Andy Whitcroft <apw@...dowen.org>
To: Andi Kleen <andi@...stfloor.org>
Cc: Jan Engelhardt <jengelh@...putergmbh.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch] checkpatch: relax spacing and line length
On Tue, Apr 08, 2008 at 08:01:14PM +0200, Andi Kleen wrote:
> Andy Whitcroft <apw@...dowen.org> writes:
> >
> > To justify changing checkpatch to loosen its checks I would hope to see
> > an agreed to change to the CodingStyle detailing actually what is now
> > acceptable.
>
> Here was a concrete proposal (with patch for CodingStyle) from my side some
> time ago:
>
> http://article.gmane.org/gmane.linux.kernel/644306
Yeah, that was a good example of how to go about changinging things. As
I said on that thread I would happily change checkpatch to follow suit.
Oddly for a CodingStyle discussion there was very "discussion" at all.
It feels like people are scared of the passion that often errupts in
discussions over style.
On that particular suggestion, I would probabally be in favour, and
slightly happier to have the string on the printk line for consistency
even though that would violate the "don't hide information" rule.
-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists