linux-kernel - Re: [PATCH] Call LSM functions outside VFS helper functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E1JjwK1-0006ml-6c@pomaz-ex.szeredi.hu>
Date:	Thu, 10 Apr 2008 14:56:09 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	penguin-kernel@...ove.SAKURA.ne.jp
CC:	viro@...iv.linux.org.uk, miklos@...redi.hu, ezk@...sunysb.edu,
	akpm@...ux-foundation.org, dave@...ux.vnet.ibm.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Call LSM functions outside VFS helper functions.

Hi,

> I'm reading this thread on tenterhooks.
> If vfsmount is passed to VFS helper functions, that will make
> r/o bind mounts and AppArmor and TOMOYO Linux happy.
> But so far, it seems that "passing vfsmount makes things complicated".

If done right, it shouldn't.  At least it didn't seem to complicate
the parts that I've touched ;)

> If the conclusion became "vfsmount should not be passed to
> VFS helper functions", that's OK, but I want you to consider
> the below approach for AppArmor and TOMOYO Linux. This patch is a repost of
> http://kerneltrap.org/mailarchive/linux-fsdevel/2008/2/17/882024 .

I'm not a big fan of adding new security hooks.  Nor of moving the
existing ones to callers.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/