linux-kernel - Re: [patch] e1000=y && e1000e=m regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FE5BE8.9000206@intel.com>
Date:	Thu, 10 Apr 2008 11:26:48 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Matthew Wilcox <matthew@....cx>
CC:	Grant Grundler <grundler@...isc-linux.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Krzysztof Halasa <khc@...waw.pl>,
	Frans Pop <elendil@...net.nl>, Ingo Molnar <mingo@...e.hu>,
	jeff@...zik.org, auke-jan.h.kok@...el.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net,
	linux-pci@...ey.karlin.mff.cuni.cz, akpm@...ux-foundation.org,
	davem@...emloft.net, jesse.brandeburg@...el.com,
	john.ronciak@...el.com, bruce.w.allan@...el.com, greg@...ah.com,
	arjan@...ux.intel.com, rjw@...k.pl
Subject: Re: [patch] e1000=y && e1000e=m regression fix

Matthew Wilcox wrote:
> On Thu, Apr 10, 2008 at 11:55:03AM -0600, Grant Grundler wrote:
>> Agreed. I like Ingo's Kconfig patch which forces both drivers
>> (e1000 and e1000e) to be built the same way (ie both modules or both
>> builtin).
> 
> Uh, that's /not/ what Ingo's patch does.  His patch makes e1000 claim
> the e1000e IDs if e1000 is built-in and e1000e is a module.

It does? that's definately not the right thing to do at all, so I'd like to
retract my ACK to that patch.

We want to move users over to e1000e, because with 2.6.26 they must (or at one
point in time anyway).

I'm all for making the move easier, but I'm really against prolonging these hacks
that make people just bump their noses later. If they hit the problem now instead
of when 2.6.26 ships, then it's all for the better IMHO.

Auke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/