[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080410184027.GA21893@uranus.ravnborg.org>
Date: Thu, 10 Apr 2008 20:40:27 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Andi Kleen <andi@...stfloor.org>,
Andy Whitcroft <apw@...dowen.org>,
"H. Peter Anvin" <hpa@...or.com>,
LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
Peter Zijlstra <peterz@...radead.org>,
akpm@...ux-foundation.org, Rusty Russell <rusty@...tcorp.com.au>,
Glauber de Oliveira Costa <gcosta@...hat.com>,
Jan Beulich <jbeulich@...ell.com>,
Thomas Gleixner <tglx@...utronix.de>, pinskia@....gnu.org
Subject: Re: [PATCH] pop previous section in alternative.c
On Thu, Apr 10, 2008 at 10:55:44AM -0400, Steven Rostedt wrote:
>
> On Thu, 10 Apr 2008, Linus Torvalds wrote:
> >
> > But maybe we can see it in the resulting object file somehow, and do the
> > check there (the same way we do the init-section analysis). I assume the
> > ..size directive writes some debug info or similar, and we can create a big
> > warning when a size is unexpectedly huge and crosses section size
> > boundaries?
>
> I'm not sure how much this would help, but where I saw my red flag was
> examining the objdump and seeing this:
>
> 89: bf 69 00 00 00 mov $0x69,%edi
> 8e: e8 00 00 00 00 callq 93 <alternatives_smp_module_add+0x30>
> 8f: R_X86_64_PC32 .rodata+0x8c
>
>
> A call to .rodata??
Did you have any relocation record reflecting this reference?
The init_section stuff today rely purely on relocation
records and is easy to extend.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists