linux-kernel - Re: [PATCH linux1394-2.6.git] firewire: fw-ohci: add option for remote debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FE8FC8.8000007@s5r6.in-berlin.de>
Date:	Fri, 11 Apr 2008 00:08:08 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
CC:	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Ingo Molnar <mingo@...e.hu>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Bernhard Kaindl <bk@...e.de>
Subject: Re: [PATCH linux1394-2.6.git] firewire: fw-ohci: add option for remote
 debugging - amendment

I wrote:
>   - Open the physical DMA filter in the top half of the IRQ handler
>     and flush the necessary MMIO writes.  This is to open the filter
>     as soon as possible after bus reset.
...
> --- linux.orig/drivers/firewire/fw-ohci.c
> +++ linux/drivers/firewire/fw-ohci.c
> @@ -1309,11 +1309,6 @@ static void bus_reset_tasklet(unsigned l
>  		reg_write(ohci, OHCI1394_ConfigROMhdr, ohci->next_header);
>  	}
>  
> -#ifdef CONFIG_FIREWIRE_OHCI_REMOTE_DMA
> -	reg_write(ohci, OHCI1394_PhyReqFilterHiSet, ~0);
> -	reg_write(ohci, OHCI1394_PhyReqFilterLoSet, ~0);
> -#endif
> -
>  	spin_unlock_irqrestore(&ohci->lock, flags);
>  
>  	if (free_rom)
> @@ -1341,8 +1336,14 @@ static irqreturn_t irq_handler(int irq, 
>  	reg_write(ohci, OHCI1394_IntEventClear, event & ~OHCI1394_busReset);
>  	log_irqs(event);
>  
> -	if (event & OHCI1394_selfIDComplete)
> +	if (event & OHCI1394_selfIDComplete) {
> +#ifdef CONFIG_FIREWIRE_OHCI_REMOTE_DMA
> +		reg_write(ohci, OHCI1394_PhyReqFilterHiSet, ~0);
> +		reg_write(ohci, OHCI1394_PhyReqFilterLoSet, ~0);
> +		flush_writes(ohci);
> +#endif
>  		tasklet_schedule(&ohci->bus_reset_tasklet);
> +	}
>  

I retract this part of the patch.  Writes to PhyReqFilter have no effect 
as long as intEvent.busReset isn't cleared.  This happens in the bottom 
half of the bus reset handler (bus_reset_tasklet).

The rest of the patch stays valid.
-- 
Stefan Richter
-=====-==--- -=-- -=-==
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/