linux-kernel - Re: [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080410091057.45cbb938@core>
Date:	Thu, 10 Apr 2008 09:10:57 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, info-linux@...de.amd.com,
	jordan.crouse@....com
Subject: Re: [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture
 detection

On Wed, 9 Apr 2008 22:33:28 -0400
Andres Salomon <dilinger@...ued.net> wrote:

> 
> This is generic VSA detection.  It's used by OLPC to determine whether or
> not the BIOS contains VSA, but since other BIOSes are coming out that don't
> use the VSA (ie, tinybios), it might end up being useful for others.

NAK - but minor

This is a check for *VSA2* which is not the same as VSA1 (Cyrix one) and
for older systems that actually matters as you may have VSA1 or VSA2 and
they are detected differently.

> +/* VSA magic values */

These should be VSA2 I think

> +static inline int geode_has_vsa(void)

has_vsa2


Alan (Keeper of the ancient cyrix docs ;))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/