linux-kernel - Re: [patch] e1000=y && e1000e=m regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080411113644.GA7767@infradead.org>
Date:	Fri, 11 Apr 2008 07:36:44 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Jeff Garzik <jeff@...zik.org>, Matthew Wilcox <matthew@....cx>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>,
	e1000-list <e1000-devel@...ts.sourceforge.net>,
	linux-pci maillist <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	Greg KH <greg@...ah.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [patch] e1000=y && e1000e=m regression fix

On Fri, Apr 11, 2008 at 01:26:53PM +0200, Ingo Molnar wrote:
> really, just because you do exceedingly good things to Linux does not 
> give you a free card to do something bad to Linux in exchange. The two 
> do not cancel out each other - because the bad things _add up_ and drive 
> away users, irreversibly. To you e1000 is the center of the universe so 
> you feel the price is worth paying. For others it is not. We want the 
> good things from you and we'll say no thanks to the bad ideas. Kernel 
> developers, especially old-timers, regularly forget about that.

Hey, hey calm down.  The device moving over to e1000e shouldn never
have been added to e1000.  They're totally differnet and the only reason
they got added in thefirst time was because soemone talked intel into
it.

We discussed this a long time and came to a wide agreement it should
move out.  Now the actual transition could and should have been handled
better, but with all the pci-e hardware in a separate driver we're all
off better in the long term.

And this is not really comparable to the libata transition at all,
there's no user-visible changed.  For every distro kernel that just
builds both driver it's a completely seamless transition, and for
people who build their own kernel we should find some Kconfig trickery
to make the transition easier.  For example we could just built e1000e
when CONFIG_E1000 is set and spill a warning that starting from 1.1.2009
you will have to have CONFIG_E1000E set aswell.

> 
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/