linux-kernel - Re: [PATCH 5/7] PPS: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2008 09:47:24 -0400
From:	lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Rodolfo Giometti <giometti@...eenne.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 5/7] PPS: serial clients support.

On Fri, Apr 11, 2008 at 09:28:40AM +0100, Alan Cox wrote:
> I do not want PPS code adding to every single serial driver. That way
> lies madness. We do it once, and in the right layer. I'll take a further
> look at it after the tty->ops patch is merged. At that point we'll be in
> a good position to add the needed ops/callbacks.

I thought it just required that the uart driver call
uart_handle_dcd_change when the state of the CD changes, and all the PPS
stuff happened in that function.

That seems pretty low intrusion, since the serial driver wouldn't need
to be touched with the PPS code at all as long as it already calls the
uart_handle functions.

Now if the driver doesn't generate an IRQ whenever a status line
changes, then the driver does need to be updated to do that.  Some (like
jsm) already do, and have no need for the HARDPPS setting at all.  It
seems reasonable though that the serial drivers should already have had
support for generating interrupts when a status line changes.

-- 
Len Sorensen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/