linux-kernel - Re: regression caused by: genirq: do not leave interupts enabled on free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804111719.44833.rjw@sisk.pl>
Date:	Fri, 11 Apr 2008 17:19:43 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Jeff Garzik <jeff@...zik.org>,
	Ayaz Abdulla <aabdulla@...dia.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: regression caused by: genirq: do not leave interupts enabled on free_irq

On Friday, 11 of April 2008, Thomas Gleixner wrote:
> On Fri, 11 Apr 2008, Eric W. Biederman wrote:
> > On Fri, 2008-04-11 at 00:17 -0700, Yinghai Lu wrote:
> > > On Fri, Apr 11, 2008 at 12:14 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote:
> > > > On Fri, Apr 11, 2008 at 12:01 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > > >  > On Thu, 10 Apr 2008, Yinghai Lu wrote:
> > > >  >  > last week found:
> > > >  >  > after latest kernel kexec RHEL 5.1 or other stack kernel, the nvidia
> > > >  >  > forcedeth doesn't work anymore.
> > > >  >  >
> > > >  >  > I stared at forcedeth.c two days. and revert every patches about that
> > > >  >  > doesn't help.
> > > >  >
> > > >  >  So forcedeth does not come up again, when you kexec from linus.git
> > > >  >  into an older distro kernel. Or is it the other way round ?
> > > >  RHEL 5.1 kexec RHEL 5.1 : works
> > > >  RHEL 5.1 kexec linus kernel: works
> > > >  linus (after -rc2) kexec linus tree: works:
> > > >  linus  (after -rc2) kexec RHEL 5.1 : forcedeth will not come up
> > > >  linus ( before -rc2 include rc2) kexec RHEL 5.1 works
> > > >
> > > the forcedeth can not get IP address...
> > 
> > Sounds like you are not getting any interrupts when you receive a
> > packet.  (i.e. The interrupt line is staying disabled).
> > 
> > Is MSI an option here?  I'm wondering if we disable the MSI and
> > something is not enabling it.
> 
> Hmm, we disable the interrupt on free_irq(), but we reenable it in
> request_irq()/setup_irq(), which is called when the forcedeth driver
> initializes in the kexeced kernel. So there is some other deeper down
> problem lurking.
> 
> Yinghai, can you apply that patch to RHEL 5.1 and check, what happens
> if you do:
> 
> modprobe forcedeth
> ifup ...
> ifdown ...
> rmmod forcedeth
> modprobe forcedeth
> ifup ...
> 
> This should result in the same problem, but probably simpler to debug.

I've just got a report from a forcedeth user that it doesn't work after a
resume from RAM for him any more.  Can it be related?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/