linux-kernel - Re: [PATCH] GPIO: #include <linux/kernel.h> for might

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804111005.52041.david-b@pacbell.net>
Date:	Fri, 11 Apr 2008 10:05:51 -0700
From:	David Brownell <david-b@...bell.net>
To:	Uwe Kleine-König <Uwe.Kleine-Koenig@...i.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] GPIO: #include <linux/kernel.h> for might_sleep

On Friday 11 April 2008, Uwe Kleine-König wrote:
> I like having headers being independend of the order of inclusion.

That's a pretty unusual policy.  Not one that's generally
followed in the kernel, either ... 


> Usually I order all includes alphabetically (and grouped by linux/,
> asm/, etc.). 

If you like alphabetical, why the exception for <asm/...> ??
:)


> This doesn't work with gpio.h because then kernel.h is 
> included to late.

So include <linux/kernel.h> first.  There *is* a policy
of avoiding extra #includes ... extras slow down builds.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/