linux-kernel - Re: 2.6.25-rc8-mm2 -- kernel/sched.c:8294: error: unknown field ‘read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Apr 2008 20:55:24 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Paul Menage <menage@...gle.com>
Cc:	Miles Lane <miles.lane@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: 2.6.25-rc8-mm2 -- kernel/sched.c:8294: error: unknown field
	‘read_uint’ specified in initializer

On Fri, 2008-04-11 at 11:46 -0700, Paul Menage wrote:
> On Fri, Apr 11, 2008 at 9:55 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Fri, 2008-04-11 at 09:48 -0400, Miles Lane wrote:
> >  > CC      kernel/sched.o
> >  > kernel/sched.c:8294: error: unknown field 'read_uint' specified in initializer
> >  > kernel/sched.c:8294: warning: initialization makes integer from
> >  > pointer without a cast
> >  > kernel/sched.c:8295: error: unknown field 'write_uint' specified in initializer
> >  > kernel/sched.c:8295: warning: initialization from incompatible pointer type
> >
> >  someone mucked around with the cgroup api; this should fix it:
> >
> >  Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> >  ---
> >  diff --git a/kernel/sched.c b/kernel/sched.c
> >  index 7119895..8b4e0b6 100644
> >  --- a/kernel/sched.c
> >  +++ b/kernel/sched.c
> >  @@ -8291,8 +8291,8 @@ static struct cftype cpu_files[] = {
> >         },
> >         {
> >                 .name = "rt_period_us",
> >  -               .read_uint = cpu_rt_period_read_uint,
> >  -               .write_uint = cpu_rt_period_write_uint,
> >  +               .read_u64 = cpu_rt_period_read_uint,
> >  +               .write_u64 = cpu_rt_period_write_uint,
> >         },
> >   #endif
> >
> 
> Sorry - this change was in my original API patch (plus renaming the
> read/write functions to have u64 suffices) but I think it collided
> with the git-sched instability around the end of February.

Yeah, no worries, I recognised it the moment I looked at it. This is
just a merge artefact from changes in different trees.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/